search

hyperlog-core / hyperlog-backend

Backend for hyperlog
0 stars 0 forks source link

Move to normal views for OAuth #34

Closed BrainBuzzer closed 4 years ago

BrainBuzzer commented 4 years ago

Since the Github Authorization part will be done in a different window/tab, we'll need to remove the current JsonResponse and instead add views that say something went wrong, or successfully connected to Github.

nikochiko commented 4 years ago

Can we do this by redirecting to frontend? Like showing the message as a box?

BrainBuzzer commented 4 years ago

We cannot redirect to the frontend as the backend will be living on a completely different domain name, ie hyperlog.dev

So when the user clicks on the link, he'll be sent to the different domain, and hence it will not be possible to connect with frontend without security issues.

BrainBuzzer commented 4 years ago

Just add some rough views for now, I'll add a little more logic and design to those pages later.