hypermedia-app / shaperone

Form UI elements driven by SHACL Shapes
https://forms.hypermedia.app
MIT License
46 stars 5 forks source link

Shoelace select controls should be clearable #282

Closed tpluscode closed 1 year ago

tpluscode commented 1 year ago

This will not be enabled by default, but only when a Property Shape is explicitly annotated

[
  sh:property [
    dash:editor dash:InstancesSelectEditor ;
    sh1:clearable true ;
  ] ;
] .
changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 903c693fe974d3132fb70b37e2274d48af3c24a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | -------------------------------- | ----- | | @hydrofoil/shaperone-wc-shoelace | Patch | | @hydrofoil/shaperone-playground | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 year ago

Codecov Report

Merging #282 (903c693) into master (3cc88af) will increase coverage by 0.14%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   81.97%   82.12%   +0.14%     
==========================================
  Files         168      168              
  Lines        7994     8021      +27     
  Branches      639      639              
==========================================
+ Hits         6553     6587      +34     
+ Misses       1415     1408       -7     
  Partials       26       26              
Impacted Files Coverage Δ
packages/wc-shoelace/components/autocomplete.ts 61.26% <100.00%> (+1.44%) :arrow_up:
packages/wc-shoelace/components/enumSelect.ts 100.00% <100.00%> (ø)
packages/wc-shoelace/components/instancesSelect.ts 100.00% <100.00%> (ø)
packages/wc-shoelace/components/select.ts 95.00% <100.00%> (+17.58%) :arrow_up:
...ackages/wc-shoelace/elements/sh-sl-autocomplete.ts 83.91% <100.00%> (+1.74%) :arrow_up:
packages/wc-shoelace/lib/components.ts 100.00% <0.00%> (+28.57%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more