search

hypermystic / bookit

https://bookit-8abd4.firebaseapp.com/
MIT License
3 stars 13 forks source link

Feat: add ctrl + s functionality for saving the file #24

Closed whyang0808 closed 4 years ago

whyang0808 commented 4 years ago

Issue #7

Changes

hypermystic commented 4 years ago

Thanks for implementing this @whyang0808, https://github.com/hypermystic/bookit/commit/3117ae5890a7f07366caa754bac85c9ce9df83a6 did a small fix so that it will overwrite the ctrl+s inbuilt functionality.

whyang0808 commented 4 years ago

Thanks for implementing this @whyang0808, 3117ae5 did a small fix so that it will overwrite the ctrl+s inbuilt functionality.

You're welcome @hypermystic Seems like the KeyboardEvent.keyCode is deprecated: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode. Perhaps can use code or key.

vaibhav111tandon commented 4 years ago

@hypermystic seems that you have to go for a fix again..thanks @whyang0808