Missing Box style on example

hypernym-studio / nuxt-gsap

GSAP module for Nuxt.

MIT License

292 stars 12 forks source link

Closed Nyakuvengwa closed 3 years ago

Nyakuvengwa commented 3 years ago

I have added the missing style on example

ivodolenc commented 3 years ago

Hi and sorry for late reply, I finally find some time to dig into it.

Indeed, there is missing style for that particular example so I would happily merge it.

But before I merge your PR, I will leave you some comments for small changes.

Thanks for your time and work.

ivodolenc commented 3 years ago

1. Add a line break after <script> and before <style> tags

}
</script>
+
<style>
.box {

2. Can you please rename your commit so that it can follow commitlint convention.

Rename to → fix: add missing '.box' style for 'staggering' example

(Since you commiting missing styles, this PR belong to fix type/category. More info)

Thanks for your contribution 👍

ivodolenc commented 3 years ago

Fixed in ccae9b0