search

hyperonecom / h1-cli

Command-line interface for HyperOne platform
MIT License
6 stars 4 forks source link

yarn install, fails on node16 #560

Closed fredericosilva closed 3 years ago

fredericosilva commented 3 years ago 
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/fred/dev/wdc/h1-cli-v2/node_modules/@npmcli/run-script/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (node:events:394:28)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
gyp ERR! System Darwin 20.5.0
gyp ERR! command "/usr/local/bin/node" "/Users/fred/dev/wdc/h1-cli-v2/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /Users/fred/dev/wdc/h1-cli-v2/node_modules/node-pty
gyp ERR! node -v v16.4.0
gyp ERR! node-gyp -v v7.1.2
gyp ERR! not ok

updating node-pty solves the problem, what's the proper way of doing it?

I've no experience with lerna/yarn.

ad-m commented 3 years ago

It was requiring execute command yarn upgrade node-pty@latest in directory packages/cli-device-node.

fredericosilva commented 3 years ago

Your commit adds a new top level dependency. Was this on purpose or you updated the wrong package?