Closed Seanny123 closed 6 years ago
Thanks for the PR! Seems to work fine. The one difference I've noticed from the previous version is that it now installs the package as hyperopt-sklearn
instead of hpsklearn
. (still uses import hpsklearn
in python though). I feel like this makes more sense than the old behaviour, and better to change it now than later. There just might be some issues popping up when a PyPI release comes about.
@bjkomer fixed
Modernizes
setup.py
so that it's compatible with Windows and is less complex.Simlar to #81, I was also having trouble installing on Windows 10 with Python 3.6. Specifically, I was getting the error:
However, when I deleted the chunk:
from
setup.py
, I was able to install the package. Consequently, I've created this PR to clean upsetup.py
.I decided to copy Nengo's style of
setup.py
. Nengo has stringent setup requirements and it:setuptools
can't be found.include_package_data
, which seems to be something which should be replaced with Manifest.in anyways.