hyperoslo / Cache

:package: Nothing but Cache.
Other
2.96k stars 335 forks source link

Add privacy manifest #317

Closed kitwtnb closed 6 months ago

kitwtnb commented 6 months ago

Apple has declared that it will reject applications and SDKs without a privacy manifest starting in the spring of 2024. SDKs that use modificationDate , contentModificationDateKey need a privacy manifest, so PrivacyInfo.xcprivacy has been added.

The following document was used as a reference for setting up the file. https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api

3lvis commented 6 months ago

Thanks for this, I don't have much information regarding the privacy manifest but after a quick check this seems to work. If anyone else finds any issues please let me know.

gsbernstein commented 5 months ago

It seems like this isn't actually adding the file to the cocoapods pod. I think you need to add it to the podspec as a resource, rather than as just part of the source. Here's an example: https://github.com/devicekit/DeviceKit/blob/master/DeviceKit.podspec

I know this isn't the best place to discuss, but I can't find the original issue.

gsbernstein commented 5 months ago

I made a followup https://github.com/hyperoslo/Cache/pull/321