Closed zenangst closed 8 years ago
Personally I think it looks kinda weird that the delimiter is included in the arguments dictionary that you get when you resolve arguments. I'd like to strip it out from the key entirely.
Before
Compass.parse(url) { route, arguments in XCTAssertEqual("login:{username}:{password}", route) XCTAssertEqual(arguments["{username}"], "JohnHyperseed") XCTAssertEqual(arguments["{password}"], "secret") }
After
Compass.parse(url) { route, arguments in XCTAssertEqual("login:{username}:{password}", route) XCTAssertEqual(arguments["username"], "JohnHyperseed") XCTAssertEqual(arguments["password"], "secret") }
@zenangst Yeah, totally agree. I was thinking about that too, but forgot to tell you :smile:
@vadymmarkov look, a wild pull request appeared :sunglasses:
Personally I think it looks kinda weird that the delimiter is included in the arguments dictionary that you get when you resolve arguments. I'd like to strip it out from the key entirely.
Before
After