Closed vadymmarkov closed 8 years ago
@vadymmarkov, thanks for your PR! By analyzing the annotation information on this pull request, we identified @zenangst, @jessearmand and @onmyway133 to be potential reviewers
I agree with those ideas. I have removed Sugar as a dependency as well in my own fork.
Well, seems like it's gonna be v3 because the last released is v2. We just had a wrong one in Podspec.
🎸 🎶 🎶
This is grrreeeeat!
@zenangst @RamonGilabert @onmyway133 We kinda like to break
Compass
from time to time, so it's a brand new breaking change 😄1) Remove
Compass.parse
completion closure in favour ofLocation
struct:So instead of:
We unwrap optional
Location
:The advantage of this approach is that
Compass.parse
is not async anymore, we get the needed result straight away and can handle the case whenurn
could not be parsed.2) Refactor
Router
andRoutable
to support Mac by using type aliases. 3) Route path, arguments and fragments are scoped byLocation
struct. Makes it easier to add more properties in the future. 4) We used only 2String
methods fromSugar
and I feel like it's unnecessary to hold this dependency, especially thinking about Swift 3 where it's no longer actual. So... we don't useSugar
inCompass
anymore 😄 5) Refactor project structure to be prepared to Swift Package Manager. 6) Add Swiftlint, mention-bot and update Travis config.