hyperoslo / ImagePicker

:camera: Reinventing the way ImagePicker works.
Other
4.87k stars 677 forks source link

If shot button pressed too frequently image might loss on old iPhones #471

Open Zwei-wei opened 3 years ago

Zwei-wei commented 3 years ago

This is actually a feature request. Our UX stuff posted an issue about image lost on the old iPhone if press shot too quickly. So can we have something like func wrapperDidShotPress(_ imagePicker: ImagePickerController) and func wrapperDidShotFinish(_ imagePicker: ImagePickerController, image: UIImage) in delegate so we can do

func wrapperDidShotPress(_ imagePicker: ImagePickerController) {
        imagePicker.shotButton.isEnabled = false
}

func wrapperDidShotFinish(_ imagePicker: ImagePickerController, image: UIImage) {
        imagePicker.shotButton.isEnabled = true
}
3lvis commented 3 years ago

Thanks @Zwei-wei, happy to merge it if you make a PR!