Add Option - Githubissues

hyperoslo / Imaginary

:unicorn: Remote images, as easy as one, two, three.

https://www.hyper.no

Other

614 stars 63 forks source link

Add Option #59

Closed onmyway133 closed 7 years ago

onmyway133 commented 7 years ago

Add Option to specify options when fetching image for imageView.
The old Configuration is for global thing, like tracking and default storage.
With Option, users have the chance to specify ImageProcessing and ImageDisplaying object to handle
There's default SimpleImageDisplayer that allows animation options to be passed
The ImageDrawer has been removed, ping @zenangst , in favor of TintImageProcessor
Add tests for SimpleImageDisplayer and ImageView+Imaginary

onmyway133 commented 7 years ago

I really like this PR, each has single responsibility, with Option and Configuration. The Option also allows injecting your own ImageFetcher. And there are tests 🎉 Let me know what you think @hyperoslo/ios ?