search

hyperoslo / Imaginary

:unicorn: Remote images, as easy as one, two, three.
https://www.hyper.no
Other
614 stars 63 forks source link

XCode 10 GM and Swift 4.2 fails to build #86

Closed jlaws closed 6 years ago

jlaws commented 6 years ago 
/Users/joelaws/Workspace/kratos/Pods/Imaginary/Sources/iOS/ImageViewDisplayer.swift:8:32: 'UIViewAnimationOptions' has been renamed to 'UIView.AnimationOptions'
/Users/joelaws/Workspace/kratos/Pods/UIKit.UIViewAnimationOptions:3:18: 'UIViewAnimationOptions' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/Imaginary/Sources/Shared/Library/Option.swift:26:48: Cannot invoke initializer for type 'ImageViewDisplayer' with no arguments
/Users/joelaws/Workspace/kratos/Pods/Imaginary/Sources/iOS/ImageViewDisplayer.swift:6:32: 'UIViewAnimationOptions' has been renamed to 'UIView.AnimationOptions'
/Users/joelaws/Workspace/kratos/Pods/UIKit.UIViewAnimationOptions:3:18: 'UIViewAnimationOptions' was obsoleted in Swift 4.2
doctorcolinsmith commented 6 years ago

This is blocking me on updating my app to Swift 4.2. It would be great if the fixes for the above could be also applied to the 3.x releases as I am using Cache 4.x elsewhere in my app.

onmyway133 commented 6 years ago

@jlaws @doctorcolinsmith Hi, sorry for the delay. I just pushed https://github.com/hyperoslo/Imaginary/releases/tag/4.2.0

jlaws commented 6 years ago

Works great, thank you!