search

hyperoslo / Lightbox

:milky_way: A convenient and easy to use image viewer for your iOS app
https://www.hyper.no
Other
1.64k stars 329 forks source link

XCode 10 GM and Swift 4.2 fail to build #204

Closed jlaws closed 6 years ago

jlaws commented 6 years ago 
/Users/joelaws/Workspace/kratos/Pods/Lightbox/Source/Views/LoadingIndicator.swift:16:15: 'activityIndicatorViewStyle' has been renamed to 'style'
/Users/joelaws/Workspace/kratos/Pods/UIKit.UIActivityIndicatorView:11:14: 'activityIndicatorViewStyle' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/Lightbox/Source/LightboxConfig.swift:44:40: 'NSAttributedStringKey' has been renamed to 'NSAttributedString.Key'
/Users/joelaws/Workspace/kratos/Pods/Foundation.NSAttributedStringKey:2:18: 'NSAttributedStringKey' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/Lightbox/Source/LightboxConfig.swift:61:40: 'NSAttributedStringKey' has been renamed to 'NSAttributedString.Key'
/Users/joelaws/Workspace/kratos/Pods/Foundation.NSAttributedStringKey:2:18: 'NSAttributedStringKey' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/Lightbox/Source/LightboxConfig.swift:78:40: 'NSAttributedStringKey' has been renamed to 'NSAttributedString.Key'
/Users/joelaws/Workspace/kratos/Pods/Foundation.NSAttributedStringKey:2:18: 'NSAttributedStringKey' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/Lightbox/Source/LightboxConfig.swift:95:40: 'NSAttributedStringKey' has been renamed to 'NSAttributedString.Key'
/Users/joelaws/Workspace/kratos/Pods/Foundation.NSAttributedStringKey:2:18: 'NSAttributedStringKey' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/Lightbox/Source/Views/HeaderView.swift:28:45: 'UIControlState' has been renamed to 'UIControl.State'
/Users/joelaws/Workspace/kratos/Pods/UIKit.UIControlState:2:18: 'UIControlState' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/Lightbox/Source/Views/HeaderView.swift:55:45: 'UIControlState' has been renamed to 'UIControl.State'
/Users/joelaws/Workspace/kratos/Pods/UIKit.UIControlState:2:18: 'UIControlState' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/Lightbox/Source/Views/PageView.swift:25:73: 'UIControlState' has been renamed to 'UIControl.State'
/Users/joelaws/Workspace/kratos/Pods/UIKit.UIControlState:2:18: 'UIControlState' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/Lightbox/Source/Views/InfoLabel.swift:132:20: 'NSAttributedStringKey' has been renamed to 'NSAttributedString.Key'
/Users/joelaws/Workspace/kratos/Pods/Foundation.NSAttributedStringKey:2:18: 'NSAttributedStringKey' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/Lightbox/Source/Views/InfoLabel.swift:137:48: 'NSAttributedStringKey' has been renamed to 'NSAttributedString.Key'
/Users/joelaws/Workspace/kratos/Pods/Foundation.NSAttributedStringKey:2:18: 'NSAttributedStringKey' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/Lightbox/Source/LightboxController.swift:28:35: 'UIScrollViewDecelerationRateFast' has been renamed to 'UIScrollView.DecelerationRate.fast'
/Users/joelaws/Workspace/kratos/Pods/UIKit.UIScrollViewDecelerationRateFast:3:12: 'UIScrollViewDecelerationRateFast' was obsoleted in Swift 3
/Users/joelaws/Workspace/kratos/Pods/Lightbox/Source/LightboxController.swift:302:54: Cannot convert value of type 'CATransitionType' to expected argument type 'String?'
ortegalex commented 6 years ago

fix this issue please

hainayanda commented 6 years ago

I dig and found the issue is because this library using old Cache Library. Can you please fix it?

onmyway133 commented 6 years ago

@jlaws @ortegalex @nayanda1 Hi, sorry for the delay. I just released https://github.com/hyperoslo/Lightbox/releases/tag/2.3.0

jlaws commented 6 years ago

Works great, thank you!