search

hyperoslo / Lightbox

:milky_way: A convenient and easy to use image viewer for your iOS app
https://www.hyper.no
Other
1.63k stars 329 forks source link

Keeping an image, downloaded from Internet, for future use #273

Open vitalii-tym opened 3 years ago

vitalii-tym commented 3 years ago

At the moment, if you add an image inited from an UIImage this way: LightboxImage(image: UIImage(named: "photo1")!, text: "This is an example of a remote image loaded from URL") it is going to be accessible via lightbox.[pageNumber].image.

However, this property is going to be nil if you init an image from a URL this way: LightboxImage(imageURL: URL(string: "https://cdn.arstechnica.net/2011/10/05/iphone4s_sample_apple-4e8c706-intro.jpg")!)

This is a regression, because it has already been fixed long time ago in PR https://github.com/hyperoslo/Lightbox/pull/122

This PR fixes it and makes the image to be accessible again via lightbox.[pageNumber].image in case it is inited as URL, assuming user has opened it and it was loaded.