search

hyperoslo / Lightbox

:milky_way: A convenient and easy to use image viewer for your iOS app
https://www.hyper.no
Other
1.62k stars 326 forks source link

Remove dependencies on specific image request library #287

Closed kitwtnb closed 1 year ago

kitwtnb commented 2 years ago

fix #284 .

Since it is undesirable to depend on a specific image library, removed SDWebImage dependency.
If developers use LightboxImage(imageURL:), they must also implement LightboxConfig.loadImage at the same time.
The same behavior as before can be achieved by using any image library in LightboxConfig.loadImage.

nlash-livly commented 1 year ago

Hi @3lvis, Could you please consider merging this in soon? We're still using Cache+Imaginary over here, and are leaning toward using this library. Thanks!

3lvis commented 1 year ago

@nlash-livly Merged.

Thanks @kitwtnb!