search

hyperoslo / Lightbox

:milky_way: A convenient and easy to use image viewer for your iOS app
https://www.hyper.no
Other
1.62k stars 326 forks source link

Development question #296

Closed alexanderkhitev closed 1 year ago

alexanderkhitev commented 1 year ago

Hey guys! Thank you for creating this great framework. I just investigate the code and I'm wondering about one thing. Why did you use UIScrollView as the base view instead UICollectionView?

3lvis commented 1 year ago

Hi,

I would assume it's because UIScrollView is more versatile and no specific features from UICollectionView where required at the time.

alexanderkhitev commented 1 year ago

Hi,

I would assume it's because UIScrollView is more versatile and no specific features from UICollectionView where required at the time.

Ok, thank you for answer. I just wondering about performance. For example: If the user opens a data set with ~ 1500 image items, can it be a problem? Thanks

3lvis commented 1 year ago

If I'm not mistaken Lightbox should have pagination built-in where a few screens are reused as you scroll, so 1500 image items shouldn't be a performance / memory problem.

alexanderkhitev commented 1 year ago

Hey @3lvis ! Ok, thank you!