Update to swift 4 - Githubissues

hyperoslo / Sugar

:coffee: Something sweet that goes great with your Cocoa

https://github.com/hyperoslo

Other

1.07k stars 69 forks source link

Update to swift 4 #107

Closed onmyway133 closed 7 years ago

onmyway133 commented 7 years ago

⚠️ Breaking changes ⚠️

Update swift version to swift 4
Remove unused files
Update method names

vadymmarkov commented 7 years ago

@onmyway133 I see you've removed a lot of code. Do you think we don't need it anymore?

onmyway133 commented 7 years ago

@vadymmarkov to answer your question

Remove some keyboard handlers as the only useful is the CustomKeyboardHandler
Remove swizzler as it is not recommended
Remove some string extensions are they are opinionated.
Remove custom operators as it is not recommended
Remove dispatch queue as they are very thin wrappers around DispatchQueue, and does not offer much advantages

vadymmarkov commented 7 years ago

What do you think @zenangst

zenangst commented 7 years ago

I'd rather not removing anything in this PR has it is beyond the scope for the PR. Either it is a PR that removes functionality or it is a Swift 4 migration. When it comes to removal, I'd open discussions about it instead of just removing it. Justify why it is redundant and deserves to be removed.

zenangst commented 7 years ago

Basically, the removal of all these things will be masked by the fact that it happened in a version update migration.

onmyway133 commented 7 years ago

@zenangst right, I will close this, and match PRs in smaller batches, so that we can discuss separately