hyperoslo / Sugar

:coffee: Something sweet that goes great with your Cocoa
https://github.com/hyperoslo
Other
1.07k stars 69 forks source link

Upgrade project to swift 4.2 #116

Closed technocidal closed 4 years ago

technocidal commented 5 years ago

I have made all the necessary changes to upgrade this project to swift version 4.2. This included all API changes in actual application code as well as test code. The projects produces no warnings.

Further discussion: Sugar currently offers the computed property .length on the String type. This was added to avoid typing .character.count everytime someone wanted to access the character count of a string. Since the original implementation of Sugar, Swift has since reverted back to using .count on the string type directly which renders this property meaningless. I did not want to remove it to avoid breaking existing code, but I would like to propose removing this completely.

technocidal commented 5 years ago

I have the feeling that this is not really maintained anymore. @zenangst @timkurvers I would volunteer to maintain this project.

zenangst commented 4 years ago

@cyborgthefirst I don't have permission to do anything on this repo anymore. But it seems like @lars-fosaas gave a helping hand! :)