search

hyperoslo / Tabby

⛩ A fancy tabbar
Other
103 stars 14 forks source link

Improve TabbyCell and TabbyController #5

Closed zenangst closed 8 years ago

zenangst commented 8 years ago

This PR adds some small improvements. To make Tabby behave accordingly with Fashion, it needs to set the font at the end of the configuration method to make sure that it is using the correct font.

This PR also adds a helper method on TabbyController to gain access to the current selected controller.

Some logic was in TabbyController.items {didSet} was also corrected.

zenangst commented 8 years ago

@RamonGilabert fixed the comments :)

RamonGilabert commented 8 years ago

Don't you need two * to be a comment in the documentation?

zenangst commented 8 years ago

My bad, I don't think you need it but for the sake of sanity, I added it :)

RamonGilabert commented 8 years ago

Great commit message.

zenangst commented 8 years ago

Don't mind the last commit message, doing Add * in the terminal was a mistake :)