search

hyperoslo / TimeAgo

Other
11 stars 1 forks source link

Development #9

Closed richardtop closed 9 years ago

richardtop commented 9 years ago

Fixes #8, #6, #5, #3, #2

vadymmarkov commented 9 years ago

@richardoti

  1. This PR is huge and hard to review. It's better to do smaller ones where each PR solves some specific problem. The name is Development which doesn't really explain the purpose of this PR. You could read about Git and GitHub conventions here: https://github.com/hyperoslo/playbook/blob/master/GIT_AND_GITHUB.md
  2. Please check our iOS-playbook https://github.com/hyperoslo/iOS-playbook one more time, because there I see a lot of things that needs to be fixed, like comments, indents, newlines, naming, etc.
  3. Don't see .gitignore. Now Pods directory is pushed to the repo, but it shouldn't be like that.
zenangst commented 9 years ago

Wow, that's one huge pull request. I guess it could help if the initial commit, the one that sets up the Xcode project, were not a part of the pull request.

zenangst commented 9 years ago

Oh I see now, it wasn't.

zenangst commented 9 years ago

@richardoti let's try and avoid these Godzilla-sized pull request in the future, okay? :sunglasses:

zenangst commented 9 years ago

@richardoti we never use capital letters in our branch names

zenangst commented 9 years ago

Looks like you are using 4 spaces for indentation, we stick to 2 spaces when we write Swift :bird:

vadymmarkov commented 9 years ago

@zenangst What should we do with this PR? Maybe it's better to merge it with master as it is and then @richardoti will make new feature/fix/refactor/improve pull requests?

zenangst commented 9 years ago

@vadymmarkov good idea, lets do that!