search

hyperoslo / android-playbook

MIT License
6 stars 2 forks source link

Settle on a convention for max line length #3

Open sindrenm opened 9 years ago

Damian-Lopata commented 8 years ago

We should agree on this one and update playbook. I would recommend to have marker number set to 120. In that case the whole line of code is still visible on Retina 15inch screen. This is how it looks on my screen.

screen shot 2016-01-18 at 14 43 48

What do you think @ealmdahl @jeantuffier @sindrenm @changxiangzhong ?

changxiangzhong commented 8 years ago

120 looks good for me.

jeantuffier commented 8 years ago

also fine for me

ealmdahl commented 8 years ago

120 is ok with me too

sindrenm commented 8 years ago

120 is totally fine by me, but am I the only one who thinks 4 spaces are a bit too much for indentation? I'll open another issue. (See #20.)