Feature/bulk sending of sms

JozoSalt commented 9 years ago

So this should solve: https://github.com/hyperoslo/cellular/issues/14

moved some code into methods, making it a little easier to read.
added recipients option, that should be and array of strings
added handling of recipients option in backend for sendega and coolsms
I see now that the feature was just for sendga, but I made it to coolsms also, because its nice to have the option.
I have put the responses in a hash, with key for the request number and the recipients it was sent to, and the response. It might come in handy when you actually want to use the response to something. Now both backends just return the first respons in the same way as before.

How do you want to handle responses ?

Sendenga only supports 100 destinations per request. That means in some cases it will do multiple requests
Coolsms only support one destination per request. That means each destination in recipients option will be a request.

I am happy to discuss, change or add stuff you feel is missing or could be better :)

coveralls commented 9 years ago

Coverage increased (+0.04%) to 99.73% when pulling b64043a334f980e6bcf74dbfb03aaa56321f90a5 on JozoSalt:feature/bulk_sending_of_sms into f69f9fefa871de73ef70897495bfbe9c8ff71c82 on hyperoslo:master.

timkurvers commented 9 years ago

Hi there! Great stuff.

I think returning a list of responses in case of recipients and a single response in case of recipient would be a good first start. There's another issue open (#2) which aims to solve the whole delivery/receipt problem, which might be able to solve this in one way or another.

Will leave some inline comments, too.

coveralls commented 9 years ago

Coverage increased (+0.04%) to 99.73% when pulling acf225118062adcfafb2128ab614fe5ee68f0664 on JozoSalt:feature/bulk_sending_of_sms into f69f9fefa871de73ef70897495bfbe9c8ff71c82 on hyperoslo:master.

coveralls commented 9 years ago

Coverage increased (+0.04%) to 99.73% when pulling acf225118062adcfafb2128ab614fe5ee68f0664 on JozoSalt:feature/bulk_sending_of_sms into f69f9fefa871de73ef70897495bfbe9c8ff71c82 on hyperoslo:master.

coveralls commented 9 years ago

Coverage increased (+0.04%) to 99.73% when pulling acf225118062adcfafb2128ab614fe5ee68f0664 on JozoSalt:feature/bulk_sending_of_sms into f69f9fefa871de73ef70897495bfbe9c8ff71c82 on hyperoslo:master.

coveralls commented 9 years ago

Coverage increased (+0.04%) to 99.73% when pulling 7a73e7685156cd5cf25eb7e4626c60cb9da16d95 on JozoSalt:feature/bulk_sending_of_sms into f69f9fefa871de73ef70897495bfbe9c8ff71c82 on hyperoslo:master.

coveralls commented 9 years ago

Coverage increased (+0.04%) to 99.73% when pulling 986ff97aeefdb2767564bd23fcabc35240e7b93b on JozoSalt:feature/bulk_sending_of_sms into f69f9fefa871de73ef70897495bfbe9c8ff71c82 on hyperoslo:master.

coveralls commented 9 years ago

Coverage increased (+0.04%) to 99.73% when pulling 24253dee4993cda07f227eac7be16c7633cb03a2 on JozoSalt:feature/bulk_sending_of_sms into f69f9fefa871de73ef70897495bfbe9c8ff71c82 on hyperoslo:master.

coveralls commented 9 years ago

Coverage increased (+0.04%) to 99.73% when pulling 24253dee4993cda07f227eac7be16c7633cb03a2 on JozoSalt:feature/bulk_sending_of_sms into f69f9fefa871de73ef70897495bfbe9c8ff71c82 on hyperoslo:master.

coveralls commented 9 years ago

Coverage increased (+0.04%) to 99.73% when pulling 24253dee4993cda07f227eac7be16c7633cb03a2 on JozoSalt:feature/bulk_sending_of_sms into f69f9fefa871de73ef70897495bfbe9c8ff71c82 on hyperoslo:master.

jgorset commented 9 years ago

coveralls commented 9 years ago

Coverage increased (+0.04%) to 99.73% when pulling fc716a0174c724ab7292b6bafbaad62eaf18bedb on JozoSalt:feature/bulk_sending_of_sms into f69f9fefa871de73ef70897495bfbe9c8ff71c82 on hyperoslo:master.

timkurvers commented 9 years ago

One tiny typo left: receipients should be recipients.

coveralls commented 9 years ago

Coverage increased (+0.04%) to 99.73% when pulling c6ba5e361d7a6293db6f2f5e7b7f9adcfdb3e93f on JozoSalt:feature/bulk_sending_of_sms into f69f9fefa871de73ef70897495bfbe9c8ff71c82 on hyperoslo:master.

sindrenm commented 9 years ago

:exclamation: :exclamation: :exclamation: :exclamation: :exclamation: :exclamation: :grinning:

sindrenm commented 9 years ago

Oh, and thanks. :+1:

timkurvers commented 9 years ago

Sweet! :+1:

hyperoslo / cellular

Feature/bulk sending of sms #18