search

hyperoslo / cellular

Sending and receiving SMSs with Ruby through pluggable backends.
Other
20 stars 6 forks source link

Refactor async messenger spec #23

Closed t0ggah closed 9 years ago

t0ggah commented 9 years ago

To get better structure(Given, When, Then) on the specs, I have rearranged the stubs and mocks.

jgorset commented 9 years ago

Woa woa woa. I love this. I didn't even know have_received was a thing.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.0%) to 99.48% when pulling a5671a6a11c5f0be46c68c1e59486f1976b029ff on refactor/jobs-spec into 2c0ebc1b1a00d1303b7bcfcfca702be8a2d4c684 on master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.0%) to 99.48% when pulling a5671a6a11c5f0be46c68c1e59486f1976b029ff on refactor/jobs-spec into 2c0ebc1b1a00d1303b7bcfcfca702be8a2d4c684 on master.

t0ggah commented 9 years ago

Nice! Really like that the doubles keep track of times a method is called, so you can set expectations on them.

timkurvers commented 9 years ago

Oh that's very nifty! :+1: