search

hyperskill / hs-test-python

A framework that simplifies testing educational projects for Hyperskill.
15 stars 10 forks source link

HSPC-19 Support pie plots #32

Closed inuur closed 2 years ago

inuur commented 2 years ago

Support pie plots in PlottingTest. Store data in x, y format.

aaaaaa2493 commented 2 years ago

I really recommend making so-called "universal tests" as were written for histograms here and here and for bar plots here

The idea is that you write one test for every single possible way you can write pie charts in matplotlib/pandas/seaborn. You just draw the same data in various different ways. The single test ensures that every possible way of drawing pie chart will result in the same data going to DrawingData object.

This way of testing revealed numerous bugs that were fixed before the release of support histograms and bar charts.

inuur commented 2 years ago

I really recommend making so-called "universal tests" as were written for histograms here and here and for bar plots here

The idea is that you write one test for every single possible way you can write pie charts in matplotlib/pandas/seaborn. You just draw the same data in various different ways. The single test ensures that every possible way of drawing pie chart will result in the same data going to DrawingData object.

This way of testing revealed numerous bugs that were fixed before the release of support histograms and bar charts.

I really recommend making so-called "universal tests" as were written for histograms here and here and for bar plots here

The idea is that you write one test for every single possible way you can write pie charts in matplotlib/pandas/seaborn. You just draw the same data in various different ways. The single test ensures that every possible way of drawing pie chart will result in the same data going to DrawingData object.

This way of testing revealed numerous bugs that were fixed before the release of support histograms and bar charts.

How it handles if 2 or more plots should be drawn at once?

aaaaaa2493 commented 2 years ago

@inuur

How it handles if 2 or more plots should be drawn at once?

Then there should be 2 sets of universal tests: the first set draws all possible ways of plotting just one plot The second set of tests should draw every possible way of drawing the same data that "contains" 2 plots

https://github.com/hyperskill/hs-test-python/tree/master/tests/outcomes/plot/bar/universal_tests

See folders "data_simple" and "data_2_pics" - that's 2 different sets of universal tests

inuur commented 2 years ago

@aaaaaa2493 ok, got you! Thanks for the advice.