hyperskill / hs-test

A framework that simplifies testing educational projects for Hyperskill. It is built on top of JUnit.
31 stars 10 forks source link

Added CheckLibraryVersion class for check library version #142

Closed polischuks closed 1 year ago

polischuks commented 1 year ago

Task: #HSPC-70

Dependencies

Reviewers

Description

aaaaaa2493 commented 1 year ago

Please, don't add unnecessary dependencies to the hs-test. There is gson dependency to work with JSON, use it instead.

polischuks commented 1 year ago

@aaaaaa2493 fixed:

aaaaaa2493 commented 1 year ago

@polischuks please remove the following from the dependencies

implementation 'javax.json:javax.json-api:1.1.4'
implementation 'org.glassfish:javax.json:1.1.4'
polischuks commented 1 year ago

@aaaaaa2493 fixed

polischuks commented 1 year ago

@aaaaaa2493 fixed/ removed catch blocks