search

hyperskill / hs-test

A framework that simplifies testing educational projects for Hyperskill. It is built on top of JUnit.
31 stars 10 forks source link

Prohibit using Asserts in tests #32

Closed aaaaaa2493 closed 5 years ago

aaaaaa2493 commented 5 years ago

Need to catch AssertionError in solve method and raise Fatal error

aaaaaa2493 commented 5 years ago

Updated:

1) Not AssertionError but any Error 2) Not in solve but in generateTests and check

SerVB commented 5 years ago

Why do you exclude solve? Example: solve has an invariant and it is checked by assert. And the invariant is written with a mistake and sometimes it fails. So the problem is in the solve method, it's a fatal error of the grader that should be sent to the team.

aaaaaa2493 commented 5 years ago

There is a great chance that there would be no solve method in v5 as well as generatePredefinedInputOutput and checkSolved as these methods serve a little purpose but complicate things a lot.

SerVB commented 5 years ago

Finally got it! Great plans to remove these methods, by the way :)