Return to the Mac App Store

alicerunsonfedora commented 4 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

With the release of Hyperspace Desktop v1.1.2, we updated the Electron version from v6 to v9 (see #211 and #212). These newer versions have implemented fixes that, for the most part, make Electron apps submittable to the Mac App Store again.

Describe the solution you'd like A clear and concise description of what you want to happen.

Once some key issues are fixed such as electron/electron#23828 and released, we can start building Mac App Store builds again and should try to bring Hyperspace Desktop builds back to the Mac App Store

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Using Homebrew Cask (see #135). This is still a valid option but may require some extra effort (but we should look into it).
Using alternative frontends like Setapp. Typically not the first place a person goes to get an app AFAIK.

Additional context Add any other context or screenshots about the feature request here.

v9.0.4 currently will not work with the Mac App Store due to some dead symbolic links (see electron/electron#23828) but a fix has been implemented; we're just waiting for that fix to be released soon.
The app in App Store Connect will need to be renamed to Hyperspace Desktop to avoid confusion with the potential SwiftUI project.
The documentation for building and submitting to the Mac App Store should be updated. I nearly forgot a lot of the components and had to research elsewhere to get everything I needed after I sent my MacBook in for repair.

alicerunsonfedora commented 4 years ago

The app in App Store Connect has been renamed but still uses the net.marquiskurt.hyperspace identifier. This shouldn't be too big of an issue.

alicerunsonfedora commented 4 years ago

Still receiving Private API rejections: electron/electron#24247

alicerunsonfedora commented 4 years ago

Submitted another App Store Connect review after reading updates on the issue in Electron:

alex-paterson

I haven't heard back from the app review board but after submitting my app for the third time it has now been accepted. I included the following app review notes:

My app was rejected due to "private API usage". Sounds like this may affect all electron apps. Please see this GitHub issue and reconsider whether these APIs are actually private and whether this app is worth rejecting: https://github.com/electron/electron/issues/24247

Here are links to the supposedly private API's in the Apple's public documentation:

https://developer.apple.com/documentation/accelerate/1450271-vdsp_vsma?language=objc https://developer.apple.com/documentation/accelerate/1450534-vdsp_deq22d?language=objc

semireg

7 days after appeal, the app build went from Rejected, to In Review, to Ready for Sale. 🤷‍♂️

Must have been a mistake on Apple’s side.

alicerunsonfedora commented 4 years ago

We've relaunched on the Mac App Store! 🎉

https://apps.apple.com/us/app/hyperspace-desktop/id1454139710?mt=12

hyperspacedev / hyperspace

Return to the Mac App Store #213