hyperspacedev / starlight

Experiments with a SwiftUI version of Hyperspace for macOS and iOS
Other
15 stars 0 forks source link

Add basic functionality to timelines #10

Closed alexmodrono closed 4 years ago

alexmodrono commented 4 years ago

Changes Overview
This PR makes the following changes:

While this pr was mostly focused on improving timelines, it also:

Does this PR fix, close, or implement any issues?

Known issues

Pending for review
@hyperspacedev/swift-ui

alexmodrono commented 4 years ago

The profile page appears to be fine, but I am running into this fatal error when tapping on a post from the Network tab:

2020-08-23 21:32:39.929392-0400 Hyperspace[830:147862] WF: _WebFilterIsActive returning: NO
2020-08-23 21:32:40.117865-0400 Hyperspace[830:147862] [assertion] Error acquiring assertion: <Error Domain=RBSAssertionErrorDomain Code=2 "Specified target process does not exist" UserInfo={NSLocalizedFailureReason=Specified target process does not exist}>
2020-08-23 21:32:40.117994-0400 Hyperspace[830:147862] [ProcessSuspension] 0x11decfa80 - ProcessAssertion: Failed to acquire RBS Background assertion 'WebProcess Background Assertion' for process with PID 837, error: Error Domain=RBSAssertionErrorDomain Code=2 "Specified target process does not exist" UserInfo={NSLocalizedFailureReason=Specified target process does not exist}
2020-08-23 21:32:40.119401-0400 Hyperspace[830:147862] [assertion] Error acquiring assertion: <Error Domain=RBSAssertionErrorDomain Code=2 "Specified target process does not exist" UserInfo={NSLocalizedFailureReason=Specified target process does not exist}>
2020-08-23 21:32:40.119549-0400 Hyperspace[830:147862] [ProcessSuspension] 0x11decfac0 - ProcessAssertion: Failed to acquire RBS Suspended assertion 'WebProcess Suspended Assertion' for process with PID 837, error: Error Domain=RBSAssertionErrorDomain Code=2 "Specified target process does not exist" UserInfo={NSLocalizedFailureReason=Specified target process does not exist}
Fatal error: UIKitNavigationBridge: multiple active destinations: file SwiftUI, line 0
2020-08-23 21:32:40.292135-0400 Hyperspace[830:147862] Fatal error: UIKitNavigationBridge: multiple active destinations: file SwiftUI, line 0

I am running the latest iOS/macOS betas with the latest Xcode.

Gotcha! Fixed by 29d1749b43fe389e39a91e9273c2189edba28050 :D

Instead of having multiple NavigationLinks, what I did was to reuse one, but with different destinations depending on the activation place, so now the two NavigationLinks don't get triggered at the same time.

alexmodrono commented 4 years ago

Alright so I'm merging this into data/client then.