Implement state-driven data management

hyperspacedev / starlight

Experiments with a SwiftUI version of Hyperspace for macOS and iOS

Other

15 stars 0 forks source link

Implement state-driven data management #14

Closed alexmodrono closed 3 years ago

alexmodrono commented 3 years ago

Changes Overview
This PR makes the following changes:

Introduces a new AppClient that now uses Combine and is listening for possible failures.
Adapts all the views to this new app client.
Implements a state to which views can subscribe to know when the data has finished loading.

Does this PR fix, close, or implement any issues?

[x] This PR closes, fixes, or implements the following issues.
Fixes #7

Pending for review
@hyperspacedev/swift-ui

alexmodrono commented 3 years ago

@alicerunsonfedora Hmmm, I do not seem to get them. The project compiles just fine for me, and most of the errors shown there are already fixed, or aren't correct.

For example, here

it says that on line 166 we didn't pass the queryItems argument, but line 166 is a comment.