search

hyperspy / hyperspyUI

A user interface for the hyperspy package. https://hyperspy.org/hyperspyUI
GNU General Public License v3.0
25 stars 15 forks source link

Scree plot includes too many components #117

Open thomasaarholt opened 7 years ago

thomasaarholt commented 7 years ago

The scree plot produced from Decomposition Model has no way of limiting the number of components, which makes it difficult to choose the right number. Previously the limit used to be 30 (I think?), but the new code is set to be equal to the number of channels in the signal.

vidartf commented 7 years ago

For reference, the hyperspy change is hyperspy/hyperspy#1359.

Any suggestions for how to solve this best? The simplest approach is of course to hardcode 50 in the UI code to replicate the old behavior.

jat255 commented 7 years ago

If I recall, this was chosen because if you used one of the newer PCA methods and limited the number of output components, then the hard coded value would give an error.

Maybe we could do something like "try 50 (or 30 or 40); if exception plot all components"?

On Wed, Apr 5, 2017, 6:49 AM Vidar Tonaas Fauske notifications@github.com wrote:

For reference, the hyperspy change is hyperspy/hyperspy#1359 https://github.com/hyperspy/hyperspy/pull/1359.

Any suggestions for how to solve this best? The simplest approach is of course to hardcode 50 in the UI code to replicate the old behavior.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hyperspy/hyperspyUI/issues/117#issuecomment-291824537, or mute the thread https://github.com/notifications/unsubscribe-auth/ABOBXe-Ryq_2vsHsVWeMhXtnKVfwMQGbks5rs3G4gaJpZM4M0BK_ .

thomasaarholt commented 7 years ago

Hard code it for now, as you can only use the standard PCA algorithm.