search

hyperspy / hyperspy_gui_ipywidgets

ipywidgets GUI elements for HyperSpy
GNU General Public License v3.0
11 stars 13 forks source link

Make axes gui compatible with non-linear-axis #24

Closed jlaehne closed 3 years ago

jlaehne commented 4 years ago

Description of the change

Gui for axes failed when offset or scale parameters were missing. Added checks for existance of these attributes to make the gui compatible with hyperspy-PR#1927 now continued in the non-uniform-axes branch.

Progress of the PR:

codecov[bot] commented 4 years ago

Codecov Report

Merging #24 (86aafa6) into master (b4014e1) will decrease coverage by 0.58%. The diff coverage is 59.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   85.66%   85.07%   -0.59%     
==========================================
  Files          18       18              
  Lines        1618     1642      +24     
==========================================
+ Hits         1386     1397      +11     
- Misses        232      245      +13
Impacted Files Coverage Δ
hyperspy_gui_ipywidgets/tests/test_axes.py 84.21% <40.00%> (-15.79%) :arrow_down:
hyperspy_gui_ipywidgets/axes.py 88.33% <73.33%> (-2.82%) :arrow_down:
hyperspy_gui_ipywidgets/conftest.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4014e1...86aafa6. Read the comment docs.

jlaehne commented 4 years ago

Added test, which for the moment fails (as long as non-linear-axis branch is not merged in HyperSpy).