Add osx arm64 GitHub ci

hyperspy / rosettasciio

Python library for reading and writing scientific data format

https://hyperspy.org/rosettasciio

GNU General Public License v3.0

47 stars 28 forks source link

Add osx arm64 GitHub ci #222

Closed ericpre closed 8 months ago

ericpre commented 8 months ago

https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/ https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/

Progress of the PR

[x] Add osx arm64 build to GitHub CI,
[x] Speed running test suite using all available CPUs (3 or 4) instead of only 2,
[x] Remove unnecessary parametrisation of hspy/zspy ragged signal test which was slowing down the test suite,
[n/a] update docstring (if appropriate),
[n/a] update user guide (if appropriate),
[x] add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
[x] Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
[n/a] add tests,
[x] ready for review.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (44e2d29) 86.25% compared to head (e3930b7) 86.23%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #222 +/- ## ========================================== - Coverage 86.25% 86.23% -0.02% ========================================== Files 82 82 Lines 10557 10557 Branches 2295 2295 ========================================== - Hits 9106 9104 -2 - Misses 932 934 +2 Partials 519 519 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jlaehne commented 8 months ago

In the links it sounds like the new runner is supposed to replace the existing macos runner, but it seems to me that we would now simply run an additional run?

ericpre commented 8 months ago

I couldn't find any information on when the macos-14 (using arm chips) will replace the macos-latest (using intel chips). I would expect that the intel runner will be around for a while, which also mean that once in a while we may need to update the macos-14 to a new version. We will need to test both architectures for a while.

jlaehne commented 8 months ago

OK, I just think we should also be somewhat economic on resources of test runners and try not to escalate the instances too much.