Closed ericpre closed 7 months ago
Attention: Patch coverage is 98.38710%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 86.29%. Comparing base (
921020d
) to head (d5a7ef9
). Report is 14 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
rsciio/renishaw/_api.py | 97.22% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
pre-commit.ci autofix
pre-commit.ci autofix
Looks good. Though I would clarify in the docstring/documentation more exactly what is returned. The survey image is added as additional dictionary after the map's dictionary to the same object.
For HyperSpy, I guess that translates into a stack of signals where first comes the actual map data and second the survey image?
Looks good. Though I would clarify in the docstring/documentation more exactly what is returned. The survey image is added as additional dictionary after the map's dictionary to the same object.
For HyperSpy, I guess that translates into a stack of signals where first comes the actual map data and second the survey image?
This is the same as for format that contains spectrum image and survey image or other any other data acquired simultaneously: hs.load
will return a list of signals (as oppose a stacked signal):
For example with the file from the test suite:
>>> s = hs.load(renishaw_test_streamline.wdf")
[<LumiSpectrum, title: StreamLine image acquisition 5, dimensions: (45, 49|394)>,
<Signal2D, title: , dimensions: (|376, 240)>]
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),docs/readthedocs.org:rosettasciio
build of this PR (link in github checks)