hyperspy / rosettasciio

Python library for reading and writing scientific data format
https://hyperspy.org/rosettasciio
GNU General Public License v3.0
44 stars 26 forks source link

Fix `tifffile` deprecations #262

Closed ericpre closed 1 month ago

ericpre commented 1 month ago

Deprecation failure in https://github.com/hyperspy/hyperspy-extensions-list/actions/runs/9231889542 with latest version for tifffile.

Progress of the PR

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 86.37%. Comparing base (a7327e4) to head (244cca7).

Files Patch % Lines
rsciio/tiff/_api.py 42.85% 1 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #262 +/- ## ======================================= Coverage 86.37% 86.37% ======================================= Files 83 83 Lines 10653 10654 +1 Branches 2322 2322 ======================================= + Hits 9201 9202 +1 Misses 935 935 Partials 517 517 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jlaehne commented 1 month ago
* [x]  Fetch tags from fork on azure pipelines CI,

Looks like it fetches them from github and not azure?

ericpre commented 1 month ago

I edited the description above, as this was unclear.

When running azure pipelines from https://github.com/hyperspy/rosettasciio, the tags are fetched correctly:

image

and the installed version of rosettasciio is correct (before it wasn't when running from forks): image