Closed Attolight-NTappy closed 2 weeks ago
Attention: Patch coverage is 97.51773%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 87.66%. Comparing base (
e921e77
) to head (1f5e4c5
). Report is 32 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
rsciio/digitalsurf/_api.py | 97.50% | 0 Missing and 14 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is now ready for review :)
pre-commit.ci autofix
Thanks for review!
I made a few comments and maybe it would be good to increase the coverage? There are a couple of if block which are not coverage.
Alright, wait for it I'll push some new tests later today
parse_metadata
needs to be part of the public API, this is the test that needs to be updated to take into account this change.
Ok. I thought you would not consider changing this. Hadn't realized some other modules where already deviating from the file_reader
,file_writer
norm
my bad
Ok finally I think we're there.
Thank you @Attolight-NTappy, I push some tweaks to please ruff and improve the release note.
🤩
Description of the change
This PR implements save support for digitalsurf file formats:
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),docs/readthedocs.org:rosettasciio
build of this PR (link in github checks)Minimal example of the bug fix or the new feature