Closed CSSFrancis closed 1 week ago
Attention: Patch coverage is 93.68421%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 87.88%. Comparing base (
88923bf
) to head (d7569e7
). Report is 25 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
rsciio/mrc/_api.py | 93.68% | 4 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Is it possible to downscale the size of the movie file by e.g. binning?
Is it possible to downscale the size of the movie file by e.g. binning?
Sure if that is helpful I can do that.
Is it possible to downscale the size of the movie file by e.g. binning?
Sure if that is helpful I can do that.
We download only for testing, but still 32 MB for one data format is quite heavy. So far we have 137 MB of data and the edax format is the only other one that exceeds 30 MB where it could not be reduced (usually up to 10). So wherever we can be more slim without compromising testing, we should do so: https://rosettasciio.readthedocs.io/en/latest/contributing.html#making-test-data-files
@CSSFrancis, when reviewing this PR, I start to wonder if the DE MRC metadata should be documented in the https://hyperspy.org/rosettasciio/file_specification/index.html section? What do you think?
I added references to where the .mrc file format is defined :)
pre-commit.ci autofix
One workflow fails, because some test fails which are present on main are missing from this branch - a rebase should fix it or it is merge to main.
There is a genuine test failure due to the #
character in the filename that doesn't play well with downloading the test files using pooch.
It is trying to download from the following url: https://github.com/CSSFrancis/rosettasciio/raw/de_mrc_auto/rsciio/tests/data/mrc/20241021_00405_0_Virt%20#0_sum.mrc
while the actual path is https://github.com/CSSFrancis/rosettasciio/raw/de_mrc_auto/rsciio/tests/data/mrc/20241021_00405_0_Virt%20%230_sum.mrc
In the pooch registry, the file are saved as:
'mrc/20241021_00405_0_Virt #0_sum.mrc' 3f798cf43ff1f3c39750b379a22962a4c6d2d546f1298461fabc6bced0cc876f
'mrc/20241021_00405_1_Virt #1_sum.mrc' 3f798cf43ff1f3c39750b379a22962a4c6d2d546f1298461fabc6bced0cc876f
'mrc/20241021_00405_ext1_Ext #1.mrc' 4962c3ead6547d819e22447765e93e357911bacd2905191d97d339b5cc0dd1dc
I added a third to use the custom url functionality but I think that the correct fix is that pooch parse the url. The update of the registry will fails because of the third columns and pre-commit CI will fail.
@ericpre What is the action item here? I can remove the # from the file names. That is actually just a default for the virtual detector name so it shouldn't effect any of the auto laoding.
pre-commit.ci autofix
I'll avoid self merging but @ericpre feel free to merge if you think this is good.
Renaming the files is the most simplest here and the issue with #
in the filename should be handle in pooch.
Description of the change
A few sentences and/or a bulleted list to describe and motivate the change:
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),docs/readthedocs.org:rosettasciio
build of this PR (link in github checks)Minimal example of the bug fix or the new feature
Note that this example can be useful to update the user guide.