search

hypertidy / anglr

Mesh creation and topology for spatial data (and not just geographic)
https://hypertidy.github.io/anglr/
83 stars 10 forks source link

missing `silicate::` in new_as.mesh3d.R #161

Closed gsapijaszko closed 2 years ago

gsapijaszko commented 2 years ago

There are few places where call for silicate:: is missing, like:

as.mesh3d.SC0 <- function(x, ...) {
  v <- sc_vertex(x)

instead of 

as.mesh3d.SC0 <- function(x, ...) {
  v <- silicate::sc_vertex(x)

PR on the way.

mdsumner commented 2 years ago

appreciated!

this has been backgrounded a while now but I've done quite a lot of work in the background that will be able to improve things here

gsapijaszko commented 2 years ago

Closing the issue, it was fixed. Thank you @mdsumner :)

mdsumner commented 2 years ago

you're welcome, very happy to see some interest in this!

mdsumner commented 2 years ago

also, I'm going to shift to the main branch - and hopefully delete master sometime soon