plot3d/persp3d cleanup

[mdsumner]

currently there's a mix of stuff in there, I think plot3d() is only meant to call persp3d, which in turn can call mesh3d

also

• added generic raster texturing with plot(TRI, col = BasicRaster) - why not?
• apply that across the board, and allow graphics::as.raster, raw matrix, array with 0,1 or 0,255 etc.

[mdsumner]

So, it seems to be that plot3d.class() should call persp3d() for mesh-alikes, and persp3d.class() does plot3d(as.mesh3d(x)):

 rgl:::persp3d.tri
function (x, z, ..., add = FALSE) 
{
    plot3d(as.mesh3d(x, z, ...), add = add, ...)
}
<bytecode: 0x000000003ce41c18>
<environment: namespace:rgl>
> rgl:::plot3d.tri
function (x, z, ...) 
persp3d(x, z, ...)
<bytecode: 0x000000003ce42cc8>
<environment: namespace:rgl>

[mdsumner]

Check list

check exports of generics

Check - help, links in help,

• [x] as.mesh3d
• [x] dot3d
• [x] mesh_plot
• [x] persp3d
• [x] plot3d
• [x] shade3d
• [x] wire3d

check textures

plotRGB(cc)
library(raster)
plotRGB(cc)
cc <- cc_location(raster::extent(-180, 180, -85, 85), zoom = 2, type = "mapbox.outdoors")
el <- cc_location(cc)
library(anglr)
x <- as.mesh3d(el, image_texture = cc)
plot3d(x)
plotRGB(cc)
shade3d(x)
rgl::shade3d(x)

• [x] not working as-is, but does work when tracing through manually ...

as.mesh3d

• [x] ARC does not work for lines (see https://github.com/hypertidy/anglr/issues/117)
• [x] BasicRaster
• [x] DEL/DEL0
• [x] QUAD
• [x] Spatial (sp)
• [x] TRI/TRI0
• [x] matrix (array?)
• [x] mesh3d (already in rgl)
• [x] sf/sfc/sfg
• [x] triangulation (the RTriangle one)

dot3d

• [x] ARC (works for polygons)
• [x] ARC does not work for lines (see https://github.com/hypertidy/anglr/issues/117)
• [x] BasicRaster
• [x] DEL/DEL0
• [x] PATH/PATH0
• [ ] PATH/PATH0 (doesn't work for non-closed lines, figure out and catch the cases when no triangles get created)
• [x] QUAD
• [ ] SC/SC0 (same caveats as for ARC, PATH)
• [x] SC/SC0 (when triangulatable)
• [x] Spatial
• [x] TRI/TRI0
• [x] matrix (array?)
• [x] mesh3d (already in rgl?)
• [x] sc
• [x] sf/sfc
• [ ] sfg ? (not yet)
• [x] triangulation (the RTriangle one)
• [x] trip

mesh_plot

• [x] BasicRaster
• [x] DEL/DEL0
• [x] QUAD
• [x] Spatial
• [x] TRI/TRI0
• [x] matrix (array?)
• [x] mesh3d
• [x] sf/sfc
• [ ] sfg ? (not yet)
• [x] triangulation (the RTriangle one)
• [x] check use of crs for above where relevant (Spatial, sf, raster, sc)

persp3d

• [x] BasicRaster
• [x] DEL/DEL0
• [x] QUAD
• [x] Spatial
• [x] TRI/TRI0
• [x] matrix (array?)
• [x] mesh3d (already in rgl)
• [x] sf/sfc
• [ ] sfg ? (not yet)
• [x] triangulation (the RTriangle one)

plot3d

• [x] ARC
• [x] BasicRaster
• [x] DEL/DEL0
• [x] PATH/PATH0
• [x] QUAD
• [x] SC/SC0
• [x] Spatial
• [x] TRI/TRI0
• [x] matrix (array?)
• [x] mesh3d (already in rgl)
• [ ] sc - plot the vertices if nothing else
• [x] sf/sfc
• [ ] sfg ? (not yet)
• [x] triangulation (the RTriangle one)
• [x] trip

shade3d

• [ ] ARC
• [x] BasicRaster
• [x] DEL/DEL0
• [x] PATH/PATH0
• [x] QUAD
• [x] SC/SC0
• [x] Spatial
• [x] TRI/TRI0
• [x] matrix (array?)
• [x] mesh3d (already in rgl)
• [x] sf/sfc (not sfg, PATH0 doesn't support)
• [ ] sfg ? (not yet)
• [x] triangulation (the RTriangle one)
• [ ] trip

Then, will need to go back to quadmesh and have it use these functions.

[mdsumner]

• [x] add shade3d above
• [x] sanity check on polygonal holes (cover silicate::plot too), plot, plot3d, mesh_plot, shade3d, etc. etc. PATH/0, TRI/0, DEL/0, and all the sf types in plot3d, persp3d, ...
• [x] add degenerate paths, this finally makes them useful - automatic interpolation of z, t, m_ if present and densification controlled by max_area https://github.com/hypertidy/anglr/issues/115
• [x] trip doesn't work

shade3d(as.mesh3d(trip::walrus818))
 Error: Can't use NA as column index in a tibble for assignment.
Run `rlang::last_error()` to see where the error occurred. 

[mdsumner]

good enough for now