search

hypertidy / ncmeta

Tidy NetCDF metadata
https://hypertidy.github.io/ncmeta/
11 stars 5 forks source link

Return attribute name and id. fixes #12 #13

Closed dblodgett-usgs closed 5 years ago

dblodgett-usgs commented 5 years ago

Would you like an option like "add_name = FALSE" that would maintain the old behavior? This isn't backward compatible in its current form.

mdsumner commented 5 years ago

No I think your way is better!

dblodgett-usgs commented 5 years ago

OK. Cool. The only thing I would add is to make the list column a named list, where the names are the attribute names, in addition to the attribute name column in the tibble. The way ncdf4 does attributes gets you a named list which is pretty handy. e.g. https://github.com/USGS-R/ncdfgeom/blob/master/R/get_prj.R Easy enough to name the list column after it comes back though too...