search

hypertidy / ncmeta

Tidy NetCDF metadata
https://hypertidy.github.io/ncmeta/
11 stars 5 forks source link

0.1.0 release required #35

Closed mdsumner closed 5 years ago

mdsumner commented 5 years ago

tidyr will be submitted to CRAN on 2019-09-09, and so the recent updates here for the new tidyr syntax are needed to avoid warnings

https://github.com/hypertidy/ncmeta/commit/0518c2a38cdaae508f6255344b73673bae20b87e

I'm getting notifications for tidyr via tidync, it has the new behaviour for nest() but the changes in ncmeta aren't yet on CRAN.

This means I really need to release an update before the end of August

@dblodgett-usgs how do you feel about that? I could craft a side branch if needed, but I gather a release of ncmeta would be reasonable in the next two weeks? (I will do checks of course, just wanted to give the heads up)

dblodgett-usgs commented 5 years ago

I'm available to test / work on things in the next couple weeks. So this is a good time to work on a release.

mdsumner commented 5 years ago

I'm going with 0.1.0

rasterwise

nc_meta() runs without error on all rasterwise files except for "../rasterwise/extdata/curvilinear/UERRA/test3.nc", because RNetCDF on CRAN can't read it.

mdsumner commented 5 years ago

So far so good, still waiting on winbuilder. I can submit this any time over the next week, so if you are happy let me know. I won't be able to do any stars checks, just FYI. @dblodgett-usgs

dblodgett-usgs commented 5 years ago

Here's my check list.

Anything else I should be thinking about?

dblodgett-usgs commented 5 years ago

Everything appears to check out. :shipit:

mdsumner commented 5 years ago

Awesome, thanks! I just got winbuilder back so I'm going to submit. :)

mdsumner commented 5 years ago

Done!