hypertidy / ncmeta

Tidy NetCDF metadata
https://hypertidy.github.io/ncmeta/
11 stars 5 forks source link

scale_factor_at_central_meridian for Transverse Mercator #40

Closed floriandeboissieu closed 2 years ago

floriandeboissieu commented 3 years ago

This issue is of the same kind as PR #39 : refering to CF conventions the scale factor variable name for transverse mercator is "scale_factor_at_central_meridian" instead of "scale_factor_at_projection_origin" for the others.

This PR fix it changing scaleFactor to scaleFactorCentMer and scaleFactorProjOrig depending on the case of Transverse Mercator or other. Although diff shows the whole file nc-gridmapping.R has changed, the only change is scaleFactor_gm to scaleFactorCentMer_gm and scaleFactorProjOrig_gm...

mdsumner commented 2 years ago

apologies I did not notice this - @dblodgett-usgs can you comment on this one?

dblodgett-usgs commented 2 years ago

I think this should be fine.