search

hypertidy / silicate

A general form for complex data
https://hypertidy.github.io/silicate/
53 stars 4 forks source link

crs structure is going to change #104

Closed edzer closed 4 years ago

edzer commented 4 years ago

You're using constructs like

> silicate:::get_projection.sfc
function (x, ...) 
{
    attr(x, "crs")[["proj4string"]]
}

but upcoming sf will change the structure of crs objects; see e.g. https://github.com/r-spatial/sf/issues/1225 . I will allow for a $ method that extracts a proj4string from a WKT represenation, so please change this into

    attr(x, "crs")$proj4string

if you want to stay in the proj4string realm.

mdsumner commented 4 years ago

Thanks for the heads up, you're saying we need the sf $ overload to get basic metadata? Don't bother we don't use sf

edzer commented 4 years ago

Others do, and get breaking packages because of silicate. You're on CRAN.

mdsumner commented 4 years ago

Thanks! And sorry for grumbling ...

edzer commented 4 years ago

still the case on CRAN; package eixport breaks for this reason; FYI @ibarraespinosa

mdsumner commented 4 years ago

Nearly ready, new silicate should hit CRAN within a day or so.

ibarraespinosa commented 4 years ago

Thanks. Now I will update eixport.

On Thu, Apr 9, 2020, 19:21 Michael Sumner notifications@github.com wrote:

Closed #104 https://github.com/hypertidy/silicate/issues/104.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hypertidy/silicate/issues/104#event-3220166297, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGRM74B6TORJN2HB2LJGCGDRLZC5BANCNFSM4KPYFK5A .