search

hypertidy / ximage

good image()
https://hypertidy.github.io/ximage/
Other
7 stars 1 forks source link

not passing down breaks #10

Open mdsumner opened 9 months ago

mdsumner commented 9 months ago

a very near fix is to add breaks to the arg list and do 

  if (!is.null(col)) {

      x <- matrix(palr::image_pal(x, col, breaks = breaks), dim(x)[1L], dim(x)[2L])
    } else {
      x <- (x - rg[1L])/diff(rg)

    }

at https://github.com/hypertidy/ximage/blob/0399b073fbf4e926ba20745fa20540486016d910/R/ximage.R#L183

but, palr is not matching the breaks logic exactly ... we should also use nativeRaster more