Adds support for default attributes

jcchavezs commented 3 years ago

A common use case is that users can pass default attributes to instrumentation at different levels, e.g.:

We can allow static tags being passed directly from code and also over env vars:

message AgentConfig {
    ...

    // defaultTags accept a map of tags that will be added on every span
    map<string, string> defaultTags = 4;
}

Ping @hypertrace/agent-maintainers

pavolloffay commented 3 years ago

LGTM, for the name I would consider using attributes, but the HT uses tags in the search bar so I am not sure.

davexroth commented 3 years ago

agreed, we should standardize on attributes. And I thought we had gone through and updated HT to use attributes, but maybe we missed some places. We should fix that.

jcchavezs commented 3 years ago

Yeah, makes sense to use attributes.

On Thu, 12 Nov 2020, 20:52 David Roth, notifications@github.com wrote:

agreed, we should standardize on attributes. And I thought we had gone through and updated HT to use attributes, but maybe we missed some places. We should fix that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hypertrace/agent-config/issues/21#issuecomment-726304234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYAVBWQ33V6RXGRSQ3RDSPQ4GHANCNFSM4TTVOP3A .

hypertrace / agent-config

Adds support for default attributes #21