fix: changes default configs to work with docker-compose setup

[JBAhire]

Description

• collector image build with current configs doesn't work with docker-compose setup out of the box and needs manual overriding configs like this: https://github.com/hypertrace/hypertrace/blob/main/docker/configs/hypertrace-collector/config.yml
• As we use docker based e2e test in multiple repositories maintaining these config files at every place is hard.
• That's why changing the default configs in a way it will work with docker-compose setup without any overrides.

Testing

Tested with docker-compose setup locally.

Checklist:

• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] Any dependent changes have been merged and published in downstream modules

[jcchavezs]

I am sorry I did not explain myself correctly. What I meant was that we could set the Kafka host over an env car instead of sticking to a particular name as this is very specific to docker compose setup.

On Thu, 4 Mar 2021, 09:54 Jayesh Bapu Ahire, notifications@github.com wrote:

@JBAhire commented on this pull request.

In default-config.yml https://github.com/hypertrace/hypertrace-collector/pull/45#discussion_r587276773 :

zipkin:

processors: batch:

exporters:

• logging:
• logLevel: debug
• kafka:
• protocol_version: 2.0.0
• brokers:
• • kafka-zookeeper:9092
• topic: jaeger-spans

@jcchavezs https://github.com/jcchavezs , I made ht-config as default while passing in command.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hypertrace/hypertrace-collector/pull/45#discussion_r587276773, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYARCIGFQT5WRH2ASUPLTB5DEHANCNFSM4YSS53JA .

[JBAhire]

@jcchavezs , @kotharironak, I added broker name as environment variable in ht-config file.

[jcchavezs]

Thanks @JBAhire !