search

hypertrace / hypertrace-collector

OpenTelemetry collector distribution for Hypertrace platform
6 stars 5 forks source link

chore: upgrades collector to 0.39.0. #62

Closed jcchavezs closed 2 years ago

jcchavezs commented 2 years ago

Description

This PR upgrades collector to use Otel collector 0.39.0.

laxmanchekka commented 2 years ago

@jcchavezs : I remember, in old version, we did two sets of private changes in our fork for kafka configs (compression, batch flush configs). I can see compression related configs are ported here. But I don't see flush related configs.

Just checking we are not missing to port them.

jcchavezs commented 2 years ago

@laxmanchekka you mean this one? https://github.com/hypertrace/opentelemetry-collector/pull/48/files it never went in, see https://github.com/hypertrace/opentelemetry-collector/blob/v0.33.0%2Bpatches/exporter/kafkaexporter/config.go cc @japoorv

laxmanchekka commented 2 years ago

@laxmanchekka you mean this one? https://github.com/hypertrace/opentelemetry-collector/pull/48/files it never went in, see https://github.com/hypertrace/opentelemetry-collector/blob/v0.33.0%2Bpatches/exporter/kafkaexporter/config.go cc @japoorv

Oh okay. I was underthe impression this also went in and was looking for relevant merges. Thanks for clarification. Please proceed with your changes.

tim-mwangi commented 2 years ago

@jcchavezs will you kick off a release for this to trigger an upgrade in saas-dev?