hypertrace / hypertrace-ingester

Streaming jobs for Hypertrace
Other
13 stars 16 forks source link

Merge span normalizer into grouper #384

Open surajpuvvada opened 1 year ago

surajpuvvada commented 1 year ago

This change merges span-normalizer into raw-spans-grouper to reduce 1 redundant output topic (raw-spans-from-jaeger-spans)

github-actions[bot] commented 1 year ago

Unit Test Results

  74 files   - 2    74 suites   - 2   1m 1s :stopwatch: -18s 412 tests  - 1  412 :heavy_check_mark:  - 1  0 :zzz: ±0  0 :x: ±0 

Results for commit 641a5f53. ± Comparison against base commit 48cc82f4.

codecov[bot] commented 1 year ago

Codecov Report

Merging #384 (e08b840) into main (a3bcd18) will increase coverage by 0.10%. The diff coverage is 96.29%.

@@             Coverage Diff              @@
##               main     #384      +/-   ##
============================================
+ Coverage     79.51%   79.61%   +0.10%     
+ Complexity     1410     1401       -9     
============================================
  Files           126      125       -1     
  Lines          5545     5525      -20     
  Branches        520      519       -1     
============================================
- Hits           4409     4399      -10     
+ Misses          900      891       -9     
+ Partials        236      235       -1     
Flag Coverage Δ
unit 79.61% <96.29%> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/hypertrace/ingester/HypertraceIngester.java 48.83% <ø> (-1.17%) :arrow_down:
.../normalizer/constants/SpanNormalizerConstants.java 0.00% <ø> (ø)
...ore/spannormalizer/client/ConfigServiceClient.java 90.00% <ø> (ø)
...ore/spannormalizer/config/ConfigServiceConfig.java 100.00% <ø> (ø)
...pannormalizer/fieldgenerators/FieldsGenerator.java 78.57% <ø> (ø)
...alizer/fieldgenerators/FirstMatchingKeyFinder.java 91.66% <ø> (ø)
...ormalizer/fieldgenerators/GrpcFieldsGenerator.java 96.96% <ø> (ø)
...ormalizer/fieldgenerators/HttpFieldsGenerator.java 94.47% <ø> (ø)
...lizer/fieldgenerators/ProtocolFieldsGenerator.java 100.00% <ø> (ø)
...normalizer/fieldgenerators/RpcFieldsGenerator.java 91.07% <ø> (ø)
... and 24 more

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Unit Test Results

  74 files   - 2    74 suites   - 2   1m 2s :stopwatch: -17s 412 tests  - 1  412 :heavy_check_mark:  - 1  0 :zzz: ±0  0 :x: ±0 

Results for commit 93ab8748. ± Comparison against base commit 48cc82f4.

github-actions[bot] commented 1 year ago

Unit Test Results

  75 files   - 1    75 suites   - 1   1m 20s :stopwatch: -1s 413 tests ±0  413 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit dc060e79. ± Comparison against base commit 48cc82f4.

github-actions[bot] commented 1 year ago

Unit Test Results

  75 files   - 1    75 suites   - 1   1m 13s :stopwatch: -6s 413 tests ±0  413 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit fd7aaabd. ± Comparison against base commit 48cc82f4.

github-actions[bot] commented 1 year ago

Unit Test Results

  75 files   - 1    75 suites   - 1   1m 13s :stopwatch: -6s 413 tests ±0  413 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 96936e06. ± Comparison against base commit 48cc82f4.

github-actions[bot] commented 1 year ago

Unit Test Results

  75 files   - 1    75 suites   - 1   1m 13s :stopwatch: -18s 413 tests ±0  413 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit e08b840b. ± Comparison against base commit a3bcd189.

saxenakshitiz commented 1 year ago

Is there a reason for removing span normalizer completely? This is a breaking change and will cause failure in our on-prem platform?