Closed SrikarMannepalli closed 1 year ago
Merging #410 (eedbf97) into main (dbd40a2) will increase coverage by
0.07%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #410 +/- ##
============================================
+ Coverage 79.90% 79.97% +0.07%
- Complexity 1419 1422 +3
============================================
Files 128 128
Lines 5573 5573
Branches 512 510 -2
============================================
+ Hits 4453 4457 +4
+ Misses 884 882 -2
+ Partials 236 234 -2
Flag | Coverage Δ | |
---|---|---|
unit | 79.97% <100.00%> (+0.07%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files Changed | Coverage Δ | |
---|---|---|
...ce/core/spannormalizer/jaeger/SpanDropManager.java | 94.87% <ø> (-0.13%) |
:arrow_down: |
...pannormalizer/jaeger/ExcludeSpanRuleEvaluator.java | 84.37% <100.00%> (+6.95%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
78 files ±0 78 suites ±0 1m 40s :stopwatch: -4s 417 tests ±0 417 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit a6e798af. ± Comparison against base commit 540a1591.
78 files ±0 78 suites ±0 1m 27s :stopwatch: -17s 417 tests ±0 417 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit 56160770. ± Comparison against base commit 540a1591.
78 files ±0 78 suites ±0 1m 27s :stopwatch: -4s 417 tests ±0 417 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit eedbf97b. ± Comparison against base commit dbd40a2d.
78 files ±0 78 suites ±0 1m 25s :stopwatch: -6s 417 tests ±0 417 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cbbbad0e. ± Comparison against base commit dbd40a2d.
Description
This PR updates the logic of building the full url to make port optional. It also updates the exclusion rule url filter eval to use url path as fallback in case the full url does not exist.
Testing
Added unit tests
Checklist: