hypertrace / hypertrace-ingester

Streaming jobs for Hypertrace
Other
13 stars 16 forks source link

chore: add config to exclude certain entity types from default entity span enrichment #413

Closed SrikarMannepalli closed 12 months ago

SrikarMannepalli commented 12 months ago

Description

This PR adds a Entity Span enricher config to allow for excluding certain entity types from default entity span enrichment

Testing

Added unit tests.

Checklist:

codecov[bot] commented 12 months ago

Codecov Report

Merging #413 (aa16db9) into main (70faf7e) will increase coverage by 0.00%. Report is 4 commits behind head on main. The diff coverage is 80.55%.

@@            Coverage Diff            @@
##               main     #413   +/-   ##
=========================================
  Coverage     79.88%   79.88%           
- Complexity     1419     1423    +4     
=========================================
  Files           128      128           
  Lines          5569     5584   +15     
  Branches        512      511    -1     
=========================================
+ Hits           4449     4461   +12     
- Misses          884      889    +5     
+ Partials        236      234    -2     
Flag Coverage Δ
unit 79.88% <80.55%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...cher/enrichment/clients/DefaultClientRegistry.java 0.00% <0.00%> (ø)
.../accessor/entities/TraceEntityAccessorBuilder.java 0.00% <0.00%> (ø)
...ce/core/spannormalizer/jaeger/SpanDropManager.java 94.87% <ø> (-0.13%) :arrow_down:
.../traceenricher/enrichment/EnrichmentProcessor.java 82.14% <100.00%> (+0.89%) :arrow_up:
.../accessor/entities/DefaultTraceEntityAccessor.java 96.77% <100.00%> (+0.14%) :arrow_up:
...pannormalizer/jaeger/ExcludeSpanRuleEvaluator.java 84.37% <100.00%> (+6.95%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 12 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 40s :stopwatch: -10s 418 tests +1  418 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit 821f1fee. ± Comparison against base commit 421b2be4.

github-actions[bot] commented 12 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 44s :stopwatch: -6s 418 tests +1  418 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit 81d2d2cf. ± Comparison against base commit 421b2be4.

github-actions[bot] commented 12 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 42s :stopwatch: -8s 418 tests +1  418 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit 4a3f2b96. ± Comparison against base commit 421b2be4.

github-actions[bot] commented 12 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 41s :stopwatch: -9s 418 tests +1  418 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit de548c2a. ± Comparison against base commit 421b2be4.

github-actions[bot] commented 12 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 45s :stopwatch: -5s 418 tests +1  418 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit a70cc4fa. ± Comparison against base commit 421b2be4.

aaron-steinfeld commented 12 months ago

Sorry just noticed dep check is failing. It should be required here, not sure why it's not. going to update that, can you take a look?

github-actions[bot] commented 12 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 32s :stopwatch: -18s 418 tests +1  418 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit aa16db93. ± Comparison against base commit 421b2be4.

github-actions[bot] commented 12 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 47s :stopwatch: -3s 418 tests +1  418 :heavy_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit a08d18b3. ± Comparison against base commit 421b2be4.