hypertrace / hypertrace-ingester

Streaming jobs for Hypertrace
Other
13 stars 16 forks source link

chore: remove subscribeOn on a scheduler #416

Closed saxenakshitiz closed 11 months ago

saxenakshitiz commented 11 months ago

Let the rxjava call run in the same thread. With async, it will run in threads part of async executor pool.

github-actions[bot] commented 11 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 35s :stopwatch: -19s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 6ce17317. ± Comparison against base commit 459c0ec2.

codecov[bot] commented 11 months ago

Codecov Report

Merging #416 (6ce1731) into main (459c0ec) will decrease coverage by 0.01%. The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #416      +/-   ##
============================================
- Coverage     79.87%   79.87%   -0.01%     
  Complexity     1423     1423              
============================================
  Files           128      128              
  Lines          5585     5584       -1     
  Branches        511      511              
============================================
- Hits           4461     4460       -1     
  Misses          890      890              
  Partials        234      234              
Flag Coverage Δ
unit 79.87% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../accessor/entities/DefaultTraceEntityAccessor.java 96.73% <ø> (-0.04%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

aaron-steinfeld commented 11 months ago

Let the rxjava call run in the same thread. With async, it will run in threads part of async executor pool.

These are "do later" calls - they collect and aggregate many entity updates calls, so they cannot run on the same thread

saxenakshitiz commented 11 months ago

Let the rxjava call run in the same thread. With async, it will run in threads part of async executor pool.

These are "do later" calls - they collect and aggregate many entity updates calls, so they cannot run on the same thread

This is not the streaming thread, but threads in threadpool used by async execution. It is fine to complete updates in the same thread.

github-actions[bot] commented 11 months ago

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 42s :stopwatch: -12s 418 tests ±0  418 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 46a77ac4. ± Comparison against base commit 459c0ec2.